feat: customize mapping annotation in kubernetes dependent resource #2075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
metacosm
reviewed
Oct 3, 2023
| private boolean useDefaultAnnotationsToIdentifyPrimary() { | ||
| return !(this instanceof SecondaryToPrimaryMapper) && !garbageCollected && isCreatable(); | ||
| private boolean useAnnotationsToIdentifyPrimary() { | ||
| return !garbageCollected && isCreatable(); |
There was a problem hiding this comment.
Why was the check on SecondToPrimaryMapper implementation removed?
There was a problem hiding this comment.
(Made an improvement on naming.)
So it has now different definition a little, it is not just for the default annotation. Before it was using default annotation and that was checked. Now it check if it does not use owner reference for that.
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
force-pushed
the
customize-annotation-for-resource-mapper
branch
from
54389d3 to
a060844
Compare
metacosm
approved these changes
Oct 4, 2023
csviri
added a commit
that referenced
this pull request
Oct 4, 2023
…2075) Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
added a commit
that referenced
this pull request
Oct 18, 2023
…2075) Signed-off-by: Attila Mészáros <csviri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation does not model very nicely the situation but makes it doable relatively easily.